Disable bottom hit slop of iOS back button#168
Disable bottom hit slop of iOS back button#168Manduro wants to merge 1 commit intoreact-navigation:masterfrom
Conversation
This fixes a bug where the hit area of the back button overlaps a few pixels of content below the header, making it impossible to interact with that content.
|
Does it work fine on Android? As from the code I see it's |
satya164
left a comment
satya164
left a comment
There was a problem hiding this comment.
Can you share a screenshot/gif showing the issue? We're not setting any hitSlop for iOS where this PR is adding extra hitSlop are, so I'm not understanding how it avoids extra area being overlapped
|
On Android it works fine, the hit slop does not go outside of the header bar. This shows the issue on iOS: This PR is not adding extra hitSlop. There is a default hitSlop for iOS here: https://github.com/react-navigation/stack/blob/master/src/views/TouchableItem.tsx#L64 |
|
Thanks for the clarification. Can we remove the extra hitSlop from |
3 participants
This fixes a bug where the hit area of the back button overlaps a few pixels of content below the header, making it impossible to interact with that content.